Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] #3454: make LTS the default #3455

Merged
merged 1 commit into from
May 18, 2023

Conversation

mversic
Copy link
Contributor

@mversic mversic commented May 5, 2023

Description

I noticed this while resolving an issue for a user from the community chat
We should target LTS by default

Linked issue

Closes #3454

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #3455 (c82f745) into iroha2-dev (a4d5c9f) will decrease coverage by 5.57%.
The diff coverage is 31.71%.

@@              Coverage Diff               @@
##           iroha2-dev    #3455      +/-   ##
==============================================
- Coverage       62.33%   56.77%   -5.57%     
==============================================
  Files             169      159      -10     
  Lines           31218    30866     -352     
==============================================
- Hits            19459    17523    -1936     
- Misses          11759    13343    +1584     
Impacted Files Coverage Δ
cli/src/lib.rs 0.57% <0.00%> (-68.86%) ⬇️
cli/src/main.rs 0.66% <0.00%> (-0.44%) ⬇️
cli/src/samples.rs 0.00% <0.00%> (-61.85%) ⬇️
cli/src/style.rs 0.00% <0.00%> (ø)
cli/src/torii/mod.rs 0.00% <0.00%> (-27.66%) ⬇️
cli/src/torii/routing.rs 0.00% <0.00%> (-57.11%) ⬇️
cli/src/torii/utils.rs 0.00% <0.00%> (-84.85%) ⬇️
client/src/http_default.rs 0.00% <0.00%> (-38.94%) ⬇️
client/src/lib.rs 3.84% <0.00%> (-96.16%) ⬇️
client_cli/src/main.rs 0.24% <0.00%> (-0.02%) ⬇️
... and 104 more

... and 50 files with indirect coverage changes

Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You delete configs/peer/legacy_lts, but docker-compose.yml still try to mount it, no?

@mversic
Copy link
Contributor Author

mversic commented May 5, 2023

You delete configs/peer/legacy_lts, but docker-compose.yml still try to mount it, no?

yeah, stupid of me. Fixed now

@mversic mversic marked this pull request as draft May 5, 2023 10:46
@mversic mversic force-pushed the lts_is_default branch 2 times, most recently from f42c487 to 5ae7fe8 Compare May 5, 2023 10:48
@mversic mversic marked this pull request as ready for review May 5, 2023 10:48
@mversic mversic force-pushed the lts_is_default branch 6 times, most recently from 7173ac7 to 4eed19d Compare May 5, 2023 13:13
@mversic mversic force-pushed the lts_is_default branch 2 times, most recently from 6447e92 to f5aa50b Compare May 5, 2023 13:18
@mversic mversic force-pushed the lts_is_default branch 5 times, most recently from d3c24e8 to c099c6b Compare May 5, 2023 13:37
appetrosyan
appetrosyan previously approved these changes May 8, 2023
.github/workflows/iroha2-release.yml Show resolved Hide resolved
docker-compose.dev.yml Outdated Show resolved Hide resolved
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@appetrosyan appetrosyan merged commit 38540eb into hyperledger:iroha2-dev May 18, 2023
9 of 11 checks passed
@mversic mversic deleted the lts_is_default branch May 18, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants