-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor] #3833, #2373, #3601: Split off Kagami #3841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Aug 28, 2023
0x009922
commented
Aug 28, 2023
Pull Request Test Coverage Report for Build 6035809576
💛 - Coveralls |
DCNick3
reviewed
Aug 28, 2023
71dce11
to
5930779
Compare
DCNick3
previously approved these changes
Aug 29, 2023
ilchu
reviewed
Aug 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to feel the old crutches gone. Overall structure is much more digestible too.
2755775
to
17132e4
Compare
DCNick3
previously approved these changes
Aug 31, 2023
pesterev
reviewed
Aug 31, 2023
ilchu
approved these changes
Sep 4, 2023
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
e3cadf1
to
4f5c1c8
Compare
DCNick3
approved these changes
Sep 4, 2023
mversic
pushed a commit
that referenced
this pull request
Oct 17, 2023
* [refactor]: remove Swarm from Kagami; introduce refactored `iroha_swarm` Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [refactor]: remove validator from Kagami; cleanup Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [misc]: fix workspace info, introduce `wasm_builder_cli` Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [ci]: update Genesis and Swarm cmds in scripts Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [feat]: produce workable `iroha_wasm_builder_cli` Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [feat]: enhance CLI UI with spinners Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [build]: remove `iroha_wasm_builder` dep from Kagami Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [build]: tree-shake unused spinners Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [test]: fix swarm tests Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [docs]: add README for `iroha_swarm` Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [refactor]: remove `UserInterface` struct Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [feat]: add `--outfile` arg for wasm cli Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [docs]: document how to build the default validator Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [chore]: unused imports Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [docs]: link the directory to the cli Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [docs]: enhance warning about an inlined validator Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [chore]: use stdout Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> * [refactor]: move `wasm_builder_cli` to `./tools/` Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com> --------- Signed-off-by: Dmitry Balashov <a.marcius26@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Outline:
kagami validator
kagami swarm
kagami genesis
according to the commentiroha_swarm
: according to the commentiroha_wasm_builder_cli
: a CLI aroundiroha_wasm_builder
. It replaceskagami validator
in the following way:Linked issue
Closes #3833 #2373 #3601
Benefits
kagami validator
thanks to spinners.Checklist
format
option iniroha_wasm_builder::Builder
, maybe open an issue to refactor it.iroha_swarm