Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] #3934: Migrate iroha_smart_contract_derive, iroha_executor_derive and iroha_trigger_derive to syn 2.0 #3935

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

DCNick3
Copy link
Contributor

@DCNick3 DCNick3 commented Sep 28, 2023

Description

Use syn 2.0, manyhow and darling to enhance the error messages

Linked issue

Closes #3934

Checklist

  • make sure the CI passes

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Sep 28, 2023
@coveralls
Copy link
Collaborator

coveralls commented Sep 28, 2023

Pull Request Test Coverage Report for Build 7179041936

  • 77 of 231 (33.33%) changed or added relevant lines in 9 files are covered.
  • 7112 unchanged lines in 130 files lost coverage.
  • Overall coverage decreased (-3.2%) to 56.193%

Changes Missing Coverage Covered Lines Changed/Added Lines %
smart_contract/derive/src/entrypoint.rs 0 11 0.0%
smart_contract/trigger/derive/src/lib.rs 0 11 0.0%
smart_contract/trigger/derive/src/entrypoint.rs 0 12 0.0%
smart_contract/derive/src/lib.rs 0 14 0.0%
smart_contract/executor/derive/src/lib.rs 26 45 57.78%
smart_contract/executor/derive/src/entrypoint.rs 0 26 0.0%
smart_contract/executor/derive/src/validate.rs 29 90 32.22%
Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
config/src/logger.rs 3 92.68%
data_model/derive/src/has_origin.rs 3 95.16%
Totals Coverage Status
Change from base Build 5423219773: -3.2%
Covered Lines: 23042
Relevant Lines: 41005

💛 - Coveralls

@DCNick3 DCNick3 mentioned this pull request Sep 29, 2023
12 tasks
@6r1d 6r1d force-pushed the iroha2-dev branch 2 times, most recently from 66fec94 to bf90a7d Compare October 17, 2023 11:50
@Arjentix
Copy link
Contributor

Arjentix commented Nov 3, 2023

@DCNick3 , any plans to update this? Sorry for pressure, just having a lot of openned PRs makes me feel frustrated.

Also seems like something is wrong, because there are too many lines changed...

@DCNick3
Copy link
Contributor Author

DCNick3 commented Nov 4, 2023

Yes, I am planning to get back to this after I finish the ursa replacement.

The "lots of line changed" probably comes from the history rewrite that happened not so long ago. Ig I'll have to do some git-fu to make it point to the new commits

@mversic
Copy link
Contributor

mversic commented Nov 6, 2023

Also seems like something is wrong, because there are too many lines changed...

it's because we rewrote history to fix DCO

@DCNick3 DCNick3 force-pushed the syn2-iroha-wasm branch 2 times, most recently from aaa0ad9 to aeed517 Compare November 10, 2023 12:44
@DCNick3 DCNick3 changed the title [refactor] #3934: Migrate iroha_wasm_derive and iroha_validator_derive to syn 2.0 [refactor] #3934: Migrate iroha_smart_contract_derive, iroha_executor_derive and iroha_trigger_derive to syn 2.0 Nov 10, 2023
@DCNick3 DCNick3 marked this pull request as ready for review November 10, 2023 13:34
smart_contract/derive/Cargo.toml Show resolved Hide resolved
smart_contract/executor/derive/src/lib.rs Outdated Show resolved Hide resolved
smart_contract/executor/derive/src/validate.rs Outdated Show resolved Hide resolved
@6r1d
Copy link
Contributor

6r1d commented Nov 16, 2023

Read The Docs check should be fixed by #4056

0x009922
0x009922 previously approved these changes Nov 21, 2023
0x009922
0x009922 previously approved these changes Nov 27, 2023
VAmuzing
VAmuzing previously approved these changes Dec 12, 2023
…alidator_derive` to syn 2.0

Signed-off-by: Nikita Strygin <dcnick3@users.noreply.github.com>
@DCNick3 DCNick3 merged commit 86fe3fd into hyperledger:iroha2-dev Dec 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants