Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] #4057: Fix query store message ordering issue #4058

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

Erigara
Copy link
Contributor

@Erigara Erigara commented Nov 15, 2023

Description

Previously 2 separate queues were used to send insert/ remove request to live query service which lead to issues when insert, remove were one right after another so that ordering of message processing was screwed.

Now single queue is used for messsages which guarantee that messages are processed sequentially eliminating possibility of this bug.

Linked issue

Closes #4057

Benefits

Bug is solved.

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
@Erigara Erigara added Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST labels Nov 15, 2023
@Erigara Erigara self-assigned this Nov 15, 2023
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 6878578506

  • 38 of 38 (100.0%) changed or added relevant lines in 1 file are covered.
  • 6903 unchanged lines in 128 files lost coverage.
  • Overall coverage decreased (-3.7%) to 55.708%

Files with Coverage Reduction New Missed Lines %
config/base/derive/src/view.rs 1 99.37%
config/src/block_sync.rs 1 95.0%
config/src/network.rs 1 93.75%
config/src/torii.rs 1 95.45%
config/src/wasm.rs 1 87.5%
core/src/smartcontracts/isi/block.rs 1 87.5%
config/src/kura.rs 2 79.41%
config/src/lib.rs 2 0.0%
ffi/src/option.rs 2 71.43%
config/src/genesis.rs 3 72.92%
Totals Coverage Status
Change from base Build 5423219773: -3.7%
Covered Lines: 22283
Relevant Lines: 40000

💛 - Coveralls

@mversic mversic self-assigned this Nov 16, 2023
core/src/query/store.rs Show resolved Hide resolved
@Erigara Erigara merged commit b085fef into hyperledger:iroha2-dev Nov 16, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants