Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to repair dependency which stopped working (protoc for golang) #4173

Merged
merged 7 commits into from Jan 9, 2024

Conversation

baziorek
Copy link
Member

Description

During working on PR (#4003) unfortunately dependency (not connected with the PR) stopped working. Inside the PR it can't be repaired "Pull requests from forks are not allowed to change Dockerfiles", so I'm trying to correct its from another branch of main iroha repository (not fork)

Linked issue

Closes #{issue_number}

Benefits

Iroha Hyperledger 1 starts compiling again

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
@baziorek baziorek added 1.x build dependencies Pull requests that update a dependency file labels Dec 25, 2023
@baziorek baziorek self-assigned this Dec 25, 2023
Grzegorz Bazior (Yodiss PSA) added 3 commits December 25, 2023 21:41
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
@baziorek
Copy link
Member Author

Please, do not review yet.
I tried:

  1. go install google.golang.org/protobuf/cmd/protoc-gen-go
  2. go install google.golang.org/protobuf/cmd/protoc-gen-go@latest
  3. go get -u google.golang.org/grpc
  4. go get github.com/golang/protobuf/protoc-gen-go - it was base, which was not working (Introduce an optional title parameter to the AddAssetQuantity and SubtractAssetQuantity, enhancing functionality within Iroha Core for improved message communication. Ensure corresponding handling capabilities in Iroha CLI for seamless integration. #4003 (comment))

Grzegorz Bazior (Yodiss PSA) added 3 commits January 3, 2024 15:12
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Copy link
Contributor

@6r1d 6r1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baziorek
Copy link
Member Author

baziorek commented Jan 9, 2024

LGTM

Thanks for approve. So I'll merge now:)

@baziorek baziorek merged commit 91b8b5a into main Jan 9, 2024
25 checks passed
baziorek added a commit to dominious1/iroha that referenced this pull request Jan 26, 2024
…hyperledger#4173)

* Trying to repair dependency which stopped working (protoc for golang): upgrading go

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>

---------

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Co-authored-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
baziorek added a commit to dominious1/iroha that referenced this pull request Jan 26, 2024
…hyperledger#4173)

* Trying to repair dependency which stopped working (protoc for golang): upgrading go

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>

---------

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Co-authored-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
dominious1 pushed a commit to dominious1/iroha that referenced this pull request Feb 1, 2024
…hyperledger#4173)

* Trying to repair dependency which stopped working (protoc for golang): upgrading go

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>

---------

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Co-authored-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: dominious1 <piotr567@proton.me>
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x build dependencies Pull requests that update a dependency file iroha1 The legacy version of Iroha.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants