New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trying to repair dependency which stopped working (protoc for golang) #4173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
baziorek
added
1.x
build
dependencies
Pull requests that update a dependency file
labels
Dec 25, 2023
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Please, do not review yet.
|
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
6r1d
approved these changes
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for approve. So I'll merge now:) |
baziorek
added a commit
to dominious1/iroha
that referenced
this pull request
Jan 26, 2024
…hyperledger#4173) * Trying to repair dependency which stopped working (protoc for golang): upgrading go Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl> --------- Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl> Co-authored-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
baziorek
added a commit
to dominious1/iroha
that referenced
this pull request
Jan 26, 2024
…hyperledger#4173) * Trying to repair dependency which stopped working (protoc for golang): upgrading go Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl> --------- Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl> Co-authored-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
dominious1
pushed a commit
to dominious1/iroha
that referenced
this pull request
Feb 1, 2024
…hyperledger#4173) * Trying to repair dependency which stopped working (protoc for golang): upgrading go Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl> --------- Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl> Co-authored-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl> Signed-off-by: dominious1 <piotr567@proton.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
1.x
build
dependencies
Pull requests that update a dependency file
iroha1
The legacy version of Iroha.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During working on PR (#4003) unfortunately dependency (not connected with the PR) stopped working. Inside the PR it can't be repaired "Pull requests from forks are not allowed to change Dockerfiles", so I'm trying to correct its from another branch of main iroha repository (not fork)
Linked issue
Closes #{issue_number}
Benefits
Iroha Hyperledger 1 starts compiling again
Checklist
CONTRIBUTING.md