Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed "some-host" to "localhost" in example/config.docker #4281

Merged
merged 1 commit into from Feb 14, 2024

Conversation

baziorek
Copy link
Member

@baziorek baziorek commented Feb 14, 2024

Description

In one of our config file we had database default address: "some-postgres". Those sample files are for Iroha's beginners to run Iroha as fast as possible. Telling them to change sample configs to run Iroha IMO is not helping them. Also it is making our life harder, because many times somebody was asking about "I'm doing as in instruction and it is not working".

What is more - we have few config files in example/ directory:

ls config*
config.docker  config.postgres.sample  config.sample  config-win.sample

in all of config files the host for DB is localhost, only in one of them (which I'm changing now) it is some-postgres.

Linked issue

Closes #{issue_number}

Benefits

  1. Easier for Iroha's beginners to run example
  2. Less work for us with explaining to them where to change config files
  3. Consequence in config files

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

…it is making much harder to start for beginner users

Signed-off-by: Grzegorz Bazior (Yodiss PSA) <g.bazior@yodiss.pl>
@baziorek baziorek added the 1.x label Feb 14, 2024
@baziorek baziorek self-assigned this Feb 14, 2024
Copy link
Contributor

@6r1d 6r1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks reasonable to me, thank you for the detailed description.

@baziorek baziorek merged commit 8586246 into main Feb 14, 2024
25 checks passed
@baziorek baziorek deleted the examples_changed_default_host branch February 14, 2024 11:21
@nxsaken nxsaken added the iroha1 The legacy version of Iroha. label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x iroha1 The legacy version of Iroha.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants