Changed "some-host" to "localhost" in example/config.docker #4281
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In one of our config file we had database default address: "some-postgres". Those sample files are for Iroha's beginners to run Iroha as fast as possible. Telling them to change sample configs to run Iroha IMO is not helping them. Also it is making our life harder, because many times somebody was asking about "I'm doing as in instruction and it is not working".
What is more - we have few config files in
example/
directory:in all of config files the host for DB is
localhost
, only in one of them (which I'm changing now) it issome-postgres
.iroha/example/config-win.sample
Line 5 in 88de1c6
iroha/example/config.postgres.sample
Line 7 in 88de1c6
config.sample
- this is using RocksDB instead of PostgresLinked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md