[refactor] #4229: Removed MST aggregation

[Stukalov-A-M]

Description

• Removed MST aggregation and derived methods
• Removed hash_of_payload method for Transactions
• Removed merge_signatures method
• Removed pending_transactions endpoint and derived methods

Now not fully signed tx will be declined by queue with SignatureCondition error

Linked issue

• Closes remove MST aggregation from iroha #4229

Benefits

Checklist

• I've read CONTRIBUTING.md
• I've used the standard signed-off commit format (or will squash just before merging)
• All applicable CI checks pass (or I promised to make them pass later)
• (optional) I've written unit tests for the code changes
• I replied to all comments after code review, marking all implemented changes with thumbs up

[coveralls]

Pull Request Test Coverage Report for Build 8095893403

Details

• 38 of 73 (52.05%) changed or added relevant lines in 8 files are covered.
• 3596 unchanged lines in 60 files lost coverage.
• Overall coverage decreased (-0.3%) to 56.533%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
core/src/block.rs	0	1	0.0%
core/src/sumeragi/main_loop.rs	0	1	0.0%
torii/src/lib.rs	0	1	0.0%
torii/src/routing.rs	0	1	0.0%
core/src/gossiper.rs	0	2	0.0%
core/src/queue.rs	36	41	87.8%
client_cli/src/main.rs	0	7	0.0%
client/src/client.rs	2	19	10.53%

Files with Coverage Reduction	New Missed Lines	%
core/src/sumeragi/network_topology.rs	1	98.78%
tools/kagami/src/crypto.rs	1	12.12%
data_model/src/metadata.rs	2	78.87%
primitives/src/unique_vec.rs	2	91.24%
config/src/kura.rs	3	80.0%
config/src/logger.rs	5	72.73%
logger/src/lib.rs	5	94.12%
tools/kagami/src/main.rs	5	0.0%
crypto/src/signature/secp256k1.rs	7	96.09%
data_model/src/smart_contract.rs	7	0.0%

Totals
Change from base Build 7884695009:	-0.3%
Covered Lines:	22517
Relevant Lines:	39830

---

💛 - Coveralls

[Stukalov-A-M]

@AlexStroke , could you pls. look at client_cli python tests. I removed check_mst flag from args, and assume that cli tests are dropped because of this.

[Erigara]

@Stukalov-A-M about pytests, that's right pytests use --skip-mst-check by default

[s8sato]

It seems to me that with this change, Iroha will temporarily lose the feature of multi-signature transactions.
Is that okay for you all?
My concerns are noted here #4229 (comment)

[Stukalov-A-M]

It seems to me that with this change, Iroha will temporarily lose the feature of multi-signature transactions. Is that okay for you all? My concerns are noted here #4229 (comment)

We have discussed it with @Arjentix exactly an idea to keep MST via triggers and it seems logical to divide the MST question resolving on 2 steps:

1. Remove current MST realization
2. Design a new solution for MST

[DCNick3]

This change breaks the test for me, and I don't think this change can be right without changing the expected numbers of transactions collected

[Erigara]

Yes, i fixed this test in #4319