Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: unify executor data model #4596

Closed
wants to merge 1 commit into from
Closed

feat!: unify executor data model #4596

wants to merge 1 commit into from

Conversation

0x009922
Copy link
Contributor

Description

This PR solves a few problems:

  • Allows executor define its config parameters through a single ExecutorDataModel entity.
  • Unifies parameters and permission tokens to ExecutorDataModelObject trait, having a definition_id and an arbitrary JSON payload (possible to support SCALE too): dynamic parameter value #4352
  • Parameters no longer configure Sumeragi/WASM/limits. I.e. chain wide configuration could only be set through the config file. It is temporary: this PR is a preparation for a proper implementation of chain-wide configuration: [discussion] Align configuration-related instructions with the RFC #4028
  • Removes extra PermissionTokenSchemaUpdated event. Since this action only happens during executor migration, which emits its own event ExecutorEvent::Upgraded, I also included the updated ExecutorDataModel in this event.

Linked issue

Closes #4352

@0x009922
refactor: unify executor data model
a1de115 
Signed-off-by: Dmitry Balashov <43530070+0x009922@users.noreply.github.com>
@0x009922 0x009922 self-assigned this May 16, 2024
@github-actions github-actions bot added the api-changes Changes in the API for client libraries label May 16, 2024
@0x009922 0x009922 changed the title refactor!: unify executor data model feat!: unify executor data model May 16, 2024
@0x009922
Copy link
Contributor Author

0x009922 commented May 16, 2024 •
edited
Loading

GitHub doesn't see my updated after force push... closing to reopen as #4597

@0x009922 0x009922 closed this May 16, 2024
@0x009922 0x009922 mentioned this pull request May 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s8sato s8sato Awaiting requested review from s8sato s8sato will be requested when the pull request is marked ready for review s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic will be requested when the pull request is marked ready for review mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith will be requested when the pull request is marked ready for review SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis will be requested when the pull request is marked ready for review outoftardis is a code owner

@Erigara Erigara Awaiting requested review from Erigara Erigara will be requested when the pull request is marked ready for review Erigara is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 will be requested when the pull request is marked ready for review DCNick3 is a code owner

@dima74 dima74 Awaiting requested review from dima74 dima74 will be requested when the pull request is marked ready for review dima74 is a code owner

Assignees

@0x009922 0x009922

Labels
api-changes Changes in the API for client libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dynamic parameter value
1 participant
@0x009922