-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Remove genesis signing from Iroha #4673
Merged
nxsaken
merged 7 commits into
hyperledger:main
from
dima74:diralik/remove-genesis-signing
Jun 4, 2024
Merged
refactor!: Remove genesis signing from Iroha #4673
nxsaken
merged 7 commits into
hyperledger:main
from
dima74:diralik/remove-genesis-signing
Jun 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dima74
requested review from
s8sato,
mversic,
SamHSmith,
outoftardis,
Erigara,
0x009922,
DCNick3 and
VAmuzing
as code owners
May 30, 2024 15:56
github-actions
bot
added
the
config-changes
Changes in configuration and start up of the Iroha
label
May 30, 2024
0x009922
requested changes
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but it seems you also need to update Kagami call in consistency.sh
s8sato
reviewed
May 31, 2024
dima74
force-pushed
the
diralik/remove-genesis-signing
branch
from
May 31, 2024 09:46
1e6a90a
to
35d5946
Compare
DCNick3
reviewed
May 31, 2024
mversic
reviewed
Jun 3, 2024
dima74
force-pushed
the
diralik/remove-genesis-signing
branch
from
June 3, 2024 13:31
3b36e52
to
9b4908e
Compare
mversic
previously approved these changes
Jun 3, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
dima74
force-pushed
the
diralik/remove-genesis-signing
branch
from
June 4, 2024 08:39
9b4908e
to
aeb0f90
Compare
mversic
approved these changes
Jun 4, 2024
DCNick3
approved these changes
Jun 4, 2024
5 tasks
nxsaken
pushed a commit
that referenced
this pull request
Jun 4, 2024
* refactor!: Remove genesis signing from Iroha * Rename to genesis.signed.scale * Review fixes * Fix test_env.py * Fix ChainId * Simplify GenesisTransactionBuilder * Use env for GENESIS_SIGNED_FILE in swarm --------- Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementation of #4225 (comment) partially based on #4382.
This PR includes:
kagami genesis sign
command to sign and transformgenesis.json
intogenesis.signed.scale
(SCALE serializedSignedTransaction
)genesis.private_key
removedgenesis.file
renamed togenesis.signed_file
Things left for future PRs:
--submit-genesis
CLI argument and make all peers submit genesis ?GenesisNetwork
struct (it always contains only oneGenesisTransaction
)Linked issue
Closes #4225
Closes #4382
Benefits
Checklist
CONTRIBUTING.md