-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Supply SignedBlock
instead of SignedTransaction
to peer
#4739
Merged
dima74
merged 8 commits into
hyperledger:main
from
dima74:diralik/all-peers-submit-genesis
Jun 20, 2024
Merged
refactor!: Supply SignedBlock
instead of SignedTransaction
to peer
#4739
dima74
merged 8 commits into
hyperledger:main
from
dima74:diralik/all-peers-submit-genesis
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested changes
Jun 18, 2024
mversic
previously approved these changes
Jun 19, 2024
mversic
reviewed
Jun 19, 2024
A thing that I have noticed. We don't validate genesis instructions at all anymore because there is no initial executor. This is a bug, only the 1st instruction (which is upgrade) should not be validated, all others should. Opened #4743 |
mversic
previously approved these changes
Jun 19, 2024
3bb780c
to
d15e9a8
Compare
Erigara
reviewed
Jun 19, 2024
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
d15e9a8
to
6d9e2ff
Compare
mversic
approved these changes
Jun 20, 2024
Erigara
approved these changes
Jun 20, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is first part of #4696:
topology
field togenesis.json
kagami genesis sign
to generateSignedBlock
iroha_swarm
andtest_env.py
to those changesPlanned changes for next PRs:
Benefits
Checklist
CONTRIBUTING.md