Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove kura.lock #4849

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove kura.lock #4849

wants to merge 1 commit into from
+15 −109

Conversation

dima74
Copy link
Contributor

@dima74 dima74 commented Jul 16, 2024

Description

Originally kura.lock was introduced to prevent multiple iroha instances running with the same data directory. However if iroha doesn't remove kura.lock, e.g. in case of non-graceful shutdown, it causes problem that iroha couldn't start after restart. Also usually iroha is deployed using k8s cluster where each peer lives in different container so original problem is not relevant in this case. So it is proposed to remove kura.lock.

Linked issue

Related: #4830
Related: #4848

Benefits

Remove kura.lock, allowing Iroha to restart after non-graceful shutdown

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@dima74 dima74 self-assigned this Jul 16, 2024
Erigara
Erigara approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@Erigara Erigara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mversic mversic enabled auto-merge (squash) July 16, 2024 14:46
@dima74 @mversic
fix: Remove kura.lock
6b99ebe 
Signed-off-by: Dmitry Murzin <diralik@yandex.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nxsaken nxsaken nxsaken approved these changes

@Erigara Erigara Erigara approved these changes

@s8sato s8sato Awaiting requested review from s8sato s8sato is a code owner

@mversic mversic Awaiting requested review from mversic mversic is a code owner

@SamHSmith SamHSmith Awaiting requested review from SamHSmith SamHSmith is a code owner

@outoftardis outoftardis Awaiting requested review from outoftardis outoftardis is a code owner

@0x009922 0x009922 Awaiting requested review from 0x009922 0x009922 is a code owner

@DCNick3 DCNick3 Awaiting requested review from DCNick3 DCNick3 is a code owner

Assignees

@dima74 dima74

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dima74 @nxsaken @Erigara