-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move blocks from kura to wsv IR-1047 #968
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23f3958
to
f09b43e
Compare
rkharisov
previously approved these changes
Apr 14, 2021
9b56c65
to
6142c87
Compare
rkharisov
previously approved these changes
Apr 15, 2021
e-ivkov
reviewed
Apr 15, 2021
rkharisov
previously approved these changes
Apr 16, 2021
e-ivkov
suggested changes
Apr 16, 2021
e-ivkov
reviewed
Apr 16, 2021
9364b4f
to
8cc4230
Compare
e-ivkov
previously approved these changes
Apr 16, 2021
rkharisov
previously approved these changes
Apr 19, 2021
rkharisov
previously approved these changes
Apr 26, 2021
rkharisov
previously approved these changes
Apr 26, 2021
5ff4b7f
to
404f340
Compare
rkharisov
previously approved these changes
Apr 27, 2021
rkharisov
reviewed
Apr 29, 2021
f654f74
to
9b8f1bd
Compare
Signed-off-by: i1i1 <vanyarybin1@live.ru>
rkharisov
approved these changes
Apr 29, 2021
e-ivkov
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.hyperledger.org/browse/IR-1047
Signed-off-by: i1i1 vanyarybin1@live.ru
Description of the Change
Blocks right now are in kura which supposed to be used for initialization from disk, while we have world state view which supposed to have all blocks (as name suggests and according to whitepaper).
Benefits
Queries will be easier to implement.
Possible Drawbacks
Usage Examples or Tests [optional]
Alternate Designs [optional]