This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Clarify length prefix contract #448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
Signed-off-by: David Fuelling <sappenin@gmail.com>
|
This pull request introduces 1 alert when merging 6e406ff into 9be6b8a - view on LGTM.com new alerts:
|
theotherian
approved these changes
Apr 13, 2020
sappenin
added a commit
that referenced
this pull request
Apr 13, 2020
* Fix Array Allocation * Fixes a bug in the ASN.1 OER Codecs framework that incorrectly allocates an array. * Update SendMoney example. * Improve unit test coverage. * Clarify length prefix contract (#448) * Fix Javadoc Signed-off-by: David Fuelling <sappenin@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the construction of an ASN.1 OER length-prefix. Also add better unit tests.
NOTE: This PR requires #446 to merge first.