This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Incremental scheduler changes in support of parallel scheduler #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsmitchell
reviewed
Feb 12, 2017
| Returns: a set of transaction ids | ||
| """ | ||
| # A write operation must be preceded by: | ||
| # - The "enclosing writer", which is th writer at the address or |
There was a problem hiding this comment.
Fixed in new commits.
| # predecessor of the enclosing writer. However, with the current | ||
| # data structure we can not determine the difference between readers | ||
| # so we specify them all; this is mostly harmless as it will not change | ||
| # the eventual topological sort order. |
There was a problem hiding this comment.
Is this relevant per the removal of topological sort?
There was a problem hiding this comment.
Fixed in new commits.
boydjohnson
approved these changes
Feb 13, 2017
jsmitchell
approved these changes
Feb 14, 2017
|
Rebased without code modifications. |
This implementation is more complete approach to determining the predecessors from the tree. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
This tree has very specific behavior around predecessor dependency calculations, so renaming to reflect that. Also provides a name for discussion that does not cause confusion with the state tree. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
The parallel scheduler has to determine this dependency calculation dynamically and therefore this static sorter class is not of actual use in determining the order of transactions. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
Fixes an exception where key_hash was not initialized but was used by the return statement, in the case set_items was an empty list. Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
Signed-off-by: Shawn T. Amundson <amundson@bitwise.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.