This repository has been archived by the owner on Jul 20, 2022. It is now read-only.
Add Rust CLI based on JSON-RPC API #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knkski
changed the title
knkski
force-pushed
the
jsonrpc-cli
branch
10 times, most recently
from
940ab45
to
be7a873
Compare
aludvik
requested review from
grkvlt,
peterschwarz,
vaporos,
aludvik and
dplumb94
knkski
force-pushed
the
jsonrpc-cli
branch
2 times, most recently
from
9653b84
to
871715a
Compare
knkski
force-pushed
the
jsonrpc-cli
branch
2 times, most recently
from
9ddec3e
to
c9559df
Compare
jsmitchell
approved these changes
Aug 23, 2018
added 3 commits
August 24, 2018 11:00
In order to have the Rust CLI live at cli/, we need to move the existing one elsewhere, which in this case is cli-go/. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
Adds a new CLI that talks exclusively to the JSON-RPC API. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
Adds documentation generated by `cargo doc` to general Seth docs. Signed-off-by: Kenneth Koski <knkski@bitwise.io>
dplumb94
approved these changes
Aug 24, 2018
peterschwarz
approved these changes
Aug 27, 2018
|
@peterschwarz: I think we'll need to maintain it until we have the API changes corresponding to these client changes merged, otherwise we'll be in a weird state without a complete working client. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new CLI that talks exclusively to the JSON-RPC API, and moves the old one to
cli-go/.Implements several CLI methods that don't yet have a JSON-RPC API equivalent, as this PR was submitted separately to cut down on PR size.
Doesn't include unit tests due to the CLI now being a thin client that proxies off all actual work to the API. Integration tests will be included for the CLI <-> API interactions in the JSON-RPC API follow-up PR.
Signed-off-by: Kenneth Koski knkski@bitwise.io