Polkadot: ink! 5.0
#1632
Merged
Polkadot: ink! 5.0
#1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
…oded value or the hash of it if its encoded length exceeds 32 bytes Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1632 +/- ##
==========================================
- Coverage 88.58% 88.57% -0.01%
==========================================
Files 150 150
Lines 69330 69285 -45
==========================================
- Hits 61415 61370 -45
Misses 7915 7915 ☔ View full report in Codecov by Sentry. |
seanyoung
approved these changes
Apr 3, 2024
| contract-metadata = "3.0.1" | ||
| contract-transcode = "3.0.1" | ||
| contract-metadata = "4.0.2" | ||
| contract-transcode = "4.0.2" |
There was a problem hiding this comment.
Maybe it would be nice to upgrade contract-metadata in the top-level Cargo.toml too
There was a problem hiding this comment.
I do agree but we had to keep those tests out of the workspace for some reason I can't remember
Comment on lines
+487
to
+488
| .collect::<std::collections::HashMap<&str, EventSpec<PortableForm>>>() | ||
| .drain() |
There was a problem hiding this comment.
does not seem the most efficient way but nevermind
There was a problem hiding this comment.
Well we need to keep unique signatures only (for anonymous events we don't even calculate the topic hash), so this is just the naive but easy to maintain implementation :D It should be fine as there are only so many events per contract anyways so most likely not worth to optimize here :)
LucasSte
approved these changes
Apr 3, 2024
xermicus
added a commit
to xermicus/solang
that referenced
this pull request
Apr 11, 2024
…yperledger#1632: The ABI encoder panics when trying to encoding no arguments. Previously, events always contained at least a single byte of data (empty events would have the discriminant/index of the event enum). However now, the data field for empty events is actually empty. So in codegen we check if we have to encode data first and pass a pointer to an empty buffer if not. Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
xermicus
added a commit
that referenced
this pull request
Apr 12, 2024
Slight oversight from #1632: Previously, events always contained at least a single byte of data (empty events would have the discriminant/index of the event enum). However now, the data field for empty events is actually empty, leading the ABI encoder to panic. So in codegen we check if we have to encode data first and pass a pointer to an empty buffer if not.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade Solang to be compatible with
ink!v5.0 .