build(devcontainer): enable local development via jekyll serve #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added a VSCode dev container definition that contains Ruby and Jekyll 2. Declared the gem dependencies so that `bundle install` can be used to install the build dependencies which then enable `jekyll serve` to locally host and render the themed version of the TOC website. 3. This will unlock easier modification to the theme which is a pre-condition of being able to debug CSS/theme/styling changes such as the width issues I discovered recently on the new project dashboard page where the last few columns are cut off from the view. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
tkuhrt
reviewed
Jun 3, 2024
There was a problem hiding this comment.
Is file needed to be checked in?
There was a problem hiding this comment.
@tkuhrt It's optional, but recommended to have it check in because it pins down the dependency versions used (instead of the default auto-upgrades which enable supply-chain attacks where someone takes over an open source project and then starts pushing new releases with malware).
|
I don't object to it, but I don't think I would use it. |
ryjones
approved these changes
Jun 3, 2024
tkuhrt
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle installcan be used toinstall the build dependencies which then enable
jekyll serveto locallyhost and render the themed version of the TOC website.
of being able to debug CSS/theme/styling changes such as the width issues
I discovered recently on the new project dashboard page where the last few
columns are cut off from the view.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com