Use Gradle 8 compatible API #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Web3JGradle plugin replace an API that was removed in Gradle 8 with a Gradle 8 API and an appropriate fallback. Signed-off-by: Danno Ferrin <danno@numisight.com>
gtebrean
reviewed
Apr 9, 2024
gradle.properties
Outdated
| @@ -2,6 +2,6 @@ group=org.web3j | |||
| version=4.11.2 | |||
| org.gradle.caching=true | |||
| org.gradle.parallel=true | |||
| solidityPluginVersion=0.4.0 | |||
| solidityPluginVersion=0.4.1-SNAPSHOT | |||
There was a problem hiding this comment.
revert this change because we don't provide SNAPSHOT versions for gradle plugins
Solidity plugin version will be updated here before releasing new gradle plugin
Signed-off-by: Danno Ferrin <danno@numisight.com>
Signed-off-by: Danno Ferrin <danno@numisight.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In Web3JGradle plugin replace an API that was removed in Gradle 8 with a
Gradle 8 API and an appropriate fallback.
Where should the reviewer start?
PR is only a few lines, should be self-evident.
Why is it needed?
The old getOutputDir API has been removed in Gradle 8. This prevents
the plugin from being used in Gradle 8. The chagnes use a compatable API
that also falls back to the original code if used in a very old Gradle 7
build.