Generate the ABI elements

[flefevre]

Will it be possible to generate also the ABI files in the generated folder?
It will be usefull to provide a tooling able to parse the transaction.input parameter directly?
Any idea on how to do it?

Several projects in javascritp are doint it 1

[flefevre]

In fact it seems to have code to generate the ABI element, but I am not able to see any abi.json files generated in my target folder.
any idea?

[flefevre]

I have added in my configuration the abi parameter, but no file has been generated...
does i miss something

			<groupId>org.web3j</groupId>
			<artifactId>web3j-maven-plugin</artifactId>
			<executions>
				<execution>
					<goals>
						<goal>generate-sources</goal>
					</goals>
					<phase>generate-sources</phase>
					<configuration>
						<packageName>com.cea.digitalworld.dwsmartcontracts</packageName>
						<sourceDestination>${project.basedir}/target/main/java</sourceDestination>
						<soliditySourceFiles>
							<directory>${project.basedir}/src/main/resources/solidity/</directory>
							<includes>
								<include>**/*.sol</include>
							</includes>
						</soliditySourceFiles>
						<abi>true</abi>
					</configuration>
				</execution>
			</executions>
		</plugin>

[flefevre]

I have got the code, and replace abi default value to true, it does not generate the abi coresponding json files.
Any idea?

[flefevre]

Ok, I have found at least one problem in the code.

in
Files.write(Paths.get(sourceDestination, packageName, contractName + ".json"), abiJson.getBytes());

will result in error due to the fact that the packageName directory has not been previously created.

ERROR] Could not build abi file for contract 'BCThing'
java.nio.file.NoSuchFileException: /volatile/home/fl218080/gits/fildariane/digitalworld/dwethereum/dwsmartcontracts/target/main/java/com.cea.digitalworld.dwsmartcontracts/BCThing.json
at sun.nio.fs.UnixException.translateToIOException (UnixException.java:86)
at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:102)
at sun.nio.fs.UnixException.rethrowAsIOException (UnixException.java:107)
at sun.nio.fs.UnixFileSystemProvider.newByteChannel (UnixFileSystemProvider.java:214)
at java.nio.file.spi.FileSystemProvider.newOutputStream (FileSystemProvider.java:434)
at java.nio.file.Files.newOutputStream (Files.java:216)
at java.nio.file.Files.write (Files.java:3292)
at org.web3j.mavenplugin.JavaClassGeneratorMojo.generatedAbi (JavaClassGeneratorMojo.java:169)
at org.web3j.mavenplugin.JavaClassGeneratorMojo.processResult (JavaClassGeneratorMojo.java:211)
at org.web3j.mavenplugin.JavaClassGeneratorMojo.processContractFile (JavaClassGeneratorMojo.java:159)
at org.web3j.mavenplugin.JavaClassGeneratorMojo.execute (JavaClassGeneratorMojo.java:76)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:208)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:154)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute (MojoExecutor.java:146)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject (LifecycleModuleBuilder.java:81)
at org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build (SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute (LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:290)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:194)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke (NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke (DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:498)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced (Launcher.java:289)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch (Launcher.java:229)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode (Launcher.java:415)
at org.codehaus.plexus.classworlds.launcher.Launcher.main (Launcher.java:356)
[INFO] Built Class for contract 'BCThing'

so we can update the code with

Files.write(Paths.get(sourceDestination, packageName.replace(".", "/"), contractName + ".json"), abiJson.getBytes());

so the json abi files will be located at the same place as the java source files

But I am not sure it is the right place. Because if we follow this pattern for the "binary" option generation, the solidity binaries will be located at the same place as the java source files.

moreover I think it is pertinent also to add the ABI generated files directly in the maven jar provided.
so i would like to propose to create a abi resource folder to put them

[h2mch]

Apologizes for my absence. Holiday, "Money"work, I will check the issue and PullRequest tomorrow. But thank you already for your work!

[flefevre]

No problem. Hope holidays were fun ! Do not hesitate to ask me some modifications, i need to improve my level on opensource projects. /François Le jeu. 23 août 2018 à 15:04, Heinz Marti <notifications@github.com> a écrit :

…

Apologizes for my absence. Holiday, "Money"work, I will check the issue and PullRequest tomorrow. But thank you already for your work! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFWYlCsGPeMu_uW9sJGNTzq0WdPot2KKks5uTqhRgaJpZM4VDz29> .

[h2mch]

With the newest version (0.3.5) it should be possible to generate abi or bin files. see the readme file

<outputFormat>java,bin</outputFormat>

[flefevre]

Hey cool! with the latest version ABI generation works nevertheless it put the abi files into the same destination sourceDestination in my case that matches: <sourceDestination>${project.basedir}/target/main/java</sourceDestination> so: ./target/main/java/com.cea.digitalworld.dwsmartcontracts/BCThing.json ./target/main/java/com.cea.digitalworld.dwsmartcontracts/BCCollector.json As you can see, it use the package format with dot and folder location for me it should be at a separate place to be able to manage it more easily with maven. that why in my proposition I have added also abiDestination parameter. But any way thanks to have implemented the ABI generation function! Now I will try to understand how to parse the input field of transaction to retrieve all parameters values, given the ABI definition. if you have any advice, i would appreciate. Francois

…

On Fri, Aug 24, 2018 at 4:14 PM Heinz Marti ***@***.***> wrote: With the newest version (0.3.5) it should be possible to generate abi or bin files. see the readme file <outputFormat>java,bin</outputFormat> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#27 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFWYlA4ccMtgTs-0yr_4Kxrt1JyBmxn-ks5uUAotgaJpZM4VDz29> .

-- Francois Le Fevre Management Informatique Innovation Biotechnologies Paris, France - Avant d'imprimer, pensez à l'environnement

[flefevre]

I close since the new version is able to generate the ABI files. An upgrade could be possible to put it a separate configurable folder.