-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use chainId when signing a transaction #22
Comments
Thanks for the heads up. Will update the transaction object to support this. Is it causing you any issues currently? From what Vitalik has said & the previous transaction signing mechanism should still be fine in the meantime - I didn't have any issues using it myself during last week post HF. |
great! this project help me, i will use it. |
This has been implemented. However, it's not enabled in the web3j smart contract wrappers. I'd rather wait until we have a JSON-RPC call or similar for obtaining the chainId, so users don't have to provide the chainId web3j. |
The RawTransactionManagers used by smart contract wrappers as of upcoming version 1.2 allows you to specify the chain id on all transactions. |
Have a look at the issue I've created on web3js
web3/web3.js#526
Basically the issue is that the way tx are signed has changed
The text was updated successfully, but these errors were encountered: