Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging Improvement for Filters #1919

Merged

Conversation

rvullriede
Copy link
Contributor

What does this PR do?

A one-line logging improvement that helps to identify "lost filters" (previously installed and usable but no longer available).

Where should the reviewer start?

  • Filter.java :-)

Why is it needed?

Without this the log is not clear if a requested filter was never usable or was previously used and "got lost".

@rvullriede rvullriede requested a review from conor10 as a code owner June 14, 2023 09:42
Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo NickSneo merged commit 99fb8f7 into hyperledger:master Aug 1, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants