Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add the eth_baseFee call #1920

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

rvullriede
Copy link
Contributor

What does this PR do?

Add another RPC call call "eth_baseFee".

Where should the reviewer start?

Ethereum.java

Why is it needed?

Some EVM-Chains (e.g. Avalanche, see https://docs.avax.network/quickstart/transaction-fees) provide a dedicated RPC call that returns the current base fee. This allows web3j to use such networks as a evm-compatible client that is not restricted to Ethereum alone.

@rvullriede rvullriede requested a review from conor10 as a code owner June 14, 2023 11:39
@NickSneo
Copy link
Contributor

@rvullriede Can you add some tests for your feature?

@rvullriede
Copy link
Contributor Author

@NickSneo I've added a basic test for this. I also looked at the TransactionDecoderTests but that would require adding the baseFee also to the Transaction1559 (which it technically is) and I'm not sure if you'd support such a bigger change since I assume your main focus is Ethereum, right?

@NickSneo
Copy link
Contributor

NickSneo commented Aug 1, 2023

@NickSneo I've added a basic test for this. I also looked at the TransactionDecoderTests but that would require adding the baseFee also to the Transaction1559 (which it technically is) and I'm not sure if you'd support such a bigger change since I assume your main focus is Ethereum, right?

I think this is good enough, as eth_baseFee api is exclusive to some evm-clients like Avalanche only

Copy link
Contributor

@NickSneo NickSneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NickSneo
Copy link
Contributor

NickSneo commented Aug 1, 2023

@rvullriede
Copy link
Contributor Author

Thx for the hint! Done :-)

@NickSneo
Copy link
Contributor

NickSneo commented Aug 2, 2023

Thx for the hint! Done :-)

pipeline is failing, plz run spotlessApply. Thanks

@rvullriede
Copy link
Contributor Author

Thx for the hint! Done :-)

pipeline is failing, plz run spotlessApply. Thanks

Sorry for the noise. Done.

@NickSneo NickSneo merged commit dca2524 into hyperledger:master Aug 2, 2023
4 checks passed
kustrun added a commit to Kr1ptal/web3j that referenced this pull request Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants