Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed java reserved words codegen errors #1975

Merged
merged 1 commit into from Oct 18, 2023
Merged

Fixed java reserved words codegen errors #1975

merged 1 commit into from Oct 18, 2023

Conversation

NickSneo
Copy link
Contributor

What does this PR do?

Fixes the issue where users were not able to generate java wrappers if there was any java reserved word in their solidity code or ABI file.

Where should the reviewer start?

review all files

Why is it needed?

Fixes - #1773

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #1975 (a835a28) into master (6435c35) will decrease coverage by 0.05%.
Report is 2 commits behind head on master.
The diff coverage is 75.00%.

@@             Coverage Diff              @@
##             master    #1975      +/-   ##
============================================
- Coverage     68.49%   68.45%   -0.05%     
  Complexity     3005     3005              
============================================
  Files           488      488              
  Lines         12561    12566       +5     
  Branches       1638     1642       +4     
============================================
- Hits           8604     8602       -2     
- Misses         3482     3485       +3     
- Partials        475      479       +4     
Files Coverage Δ
...n/java/org/web3j/crypto/StructuredDataEncoder.java 89.65% <100.00%> (-0.12%) ⬇️
...ava/org/web3j/codegen/SolidityFunctionWrapper.java 90.08% <72.22%> (-0.41%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@gtebrean gtebrean merged commit dba4dfb into master Oct 18, 2023
5 of 6 checks passed
@NickSneo NickSneo deleted the nicks/issue-1773 branch October 18, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants