Fix for test java wrappers with duplicate name #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2020 +/- ##
============================================
+ Coverage 69.20% 69.23% +0.03%
- Complexity 3122 3125 +3
============================================
Files 493 493
Lines 13145 13156 +11
Branches 1695 1696 +1
============================================
+ Hits 9097 9109 +12
Misses 3557 3557
+ Partials 491 490 -1 ☔ View full report in Codecov by Sentry. |
gtebrean
requested changes
Mar 20, 2024
codegen/src/test/java/org/web3j/codegen/unit/gen/java/MethodParserTest.java
Show resolved
Hide resolved
codegen/src/main/java/org/web3j/codegen/unit/gen/MethodFilter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
gtebrean
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds logic to fix bug where test java wrapper methods have duplicate name
Where should the reviewer start?
review all files
Why is it needed?
Bug fix for test java wrapper