[issue#671] Fix smart contract code generators by generating two more…

[franz-see]

… constructors on the SolidityFunctionWrapper generated classes:

• protected (String contractAddress, Web3j web3j, Credentials credentials, ContractGasProvider gasProvider) {}
• protected (String contractAddress, Web3j web3j, TransactionManager transactionManager, ContractGasProvider gasProvider) {}

[codecov]

Codecov Report

Merging #672 into release/3.6 will decrease coverage by 0.1%.
The diff coverage is 90.9%.

@@               Coverage Diff               @@
##             release/3.6   #672      +/-   ##
===============================================
- Coverage          77.11%    77%   -0.11%     
  Complexity          1794   1794              
===============================================
  Files                239    239              
  Lines               6667   6679      +12     
  Branches             996    996              
===============================================
+ Hits                5141   5143       +2     
- Misses              1275   1286      +11     
+ Partials             251    250       -1

Impacted Files	Coverage Δ	Complexity Δ
core/src/main/java/org/web3j/tx/Contract.java	74.66% <0%> (-1.01%)	46 <0> (ø)
...ava/org/web3j/codegen/SolidityFunctionWrapper.java	96.01% <100%> (+0.07%)	115 <1> (+1)	⬆️
...n/java/org/web3j/protocol/core/filters/Filter.java	53.12% <0%> (-14.07%)	8% <0%> (-2%)
...ore/src/main/java/org/web3j/utils/Observables.java	88% <0%> (+4%)	11% <0%> (+1%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe8c359...137c66a. Read the comment docs.

[yuriymyronovych]

@franz-see looks great!

[iikirilov]

This has been addressed in #725

[stewartsvg]

Hi, the new 4.0.1 web3j CLI tool smart contract wrappers generate a ContractGasProvider, but the latest Android version (3.3.1) of web3j do not contain this

[stewartsvg]

using web3j CLI version 3.5.0 works, is that the only workaround I can use for now? Sorry if this is not the right place to ask this question

[iikirilov]

@stewartsvg please use web3j 3.5.0 or higher

we are in progress to release the android branch - I believe a snapshot is available