make methods public #679
Closed
make methods public #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Added release build.
# Conflicts: # src/integration-test/java/org/web3j/generated/Greeter.java # src/integration-test/java/org/web3j/protocol/scenarios/FunctionWrappersIT.java # src/main/java/org/web3j/abi/Contract.java # src/main/java/org/web3j/abi/Transfer.java # src/test/java/org/web3j/utils/StringsTest.java
# Conflicts: # src/integration-test/java/org/web3j/generated/Greeter.java # src/integration-test/java/org/web3j/protocol/scenarios/Scenario.java # src/main/java/org/web3j/abi/Contract.java # src/main/java/org/web3j/abi/FunctionReturnDecoder.java # src/main/java/org/web3j/abi/datatypes/Event.java # src/main/java/org/web3j/protocol/http/HttpService.java # src/test/java/org/web3j/abi/FunctionEncoderTest.java # src/test/java/org/web3j/abi/FunctionReturnDecoderTest.java
# Conflicts: # src/main/java/org/web3j/abi/Contract.java # src/main/java/org/web3j/abi/ManagedTransaction.java # src/main/java/org/web3j/abi/Transfer.java # src/main/java/org/web3j/console/WalletSendFunds.java # src/main/java/org/web3j/crypto/Keys.java # src/main/java/org/web3j/protocol/http/HttpService.java # src/main/java/org/web3j/utils/Async.java
moved away from apache httpclient
# Conflicts: # build.gradle # src/integration-test/java/org/web3j/protocol/core/CoreIT.java # src/integration-test/java/org/web3j/protocol/scenarios/Scenario.java # src/main/java/org/web3j/abi/Contract.java # src/main/java/org/web3j/abi/ManagedTransaction.java # src/main/java/org/web3j/codegen/AbiTypesGenerator.java # src/main/java/org/web3j/codegen/AbiTypesMapperGenerator.java # src/main/java/org/web3j/protocol/Web3j.java # src/main/java/org/web3j/protocol/core/JsonRpc2_0Web3j.java # src/main/java/org/web3j/protocol/core/Request.java # src/main/java/org/web3j/protocol/http/HttpService.java # src/main/java/org/web3j/utils/Async.java # src/test/java/org/web3j/codegen/SolidityFunctionWrapperGeneratorTest.java # src/test/java/org/web3j/protocol/ResponseTester.java
# Conflicts: # build.gradle # src/integration-test/java/org/web3j/protocol/core/CoreIT.java # src/integration-test/java/org/web3j/protocol/scenarios/Scenario.java # src/main/java/org/web3j/abi/Contract.java # src/main/java/org/web3j/abi/ManagedTransaction.java # src/main/java/org/web3j/codegen/AbiTypesGenerator.java # src/main/java/org/web3j/codegen/AbiTypesMapperGenerator.java # src/main/java/org/web3j/protocol/Web3j.java # src/main/java/org/web3j/protocol/core/JsonRpc2_0Web3j.java # src/main/java/org/web3j/protocol/core/Request.java # src/main/java/org/web3j/protocol/http/HttpService.java # src/main/java/org/web3j/utils/Async.java # src/test/java/org/web3j/codegen/SolidityFunctionWrapperGeneratorTest.java # src/test/java/org/web3j/protocol/ResponseTester.java
# Conflicts: # src/main/java/org/web3j/utils/Async.java
made sure to not include the cloned SafeVarargs class in the final build
Prepare web3j-android v3.3.0
fix incompatible code
# Conflicts: # build.gradle
|
@UnknownEnergy I presume you made this change as the Android branch hasn't caught up to master yet? It should be brought up to date shortly. |
conor10
reviewed
Sep 26, 2018
There was a problem hiding this comment.
This will probably make sense to close depending on @UnknownEnergy response to my query.
|
@conor10 As far as I remember this methods were private but if Android branch now caught up with master were it is public then this issue can be closed yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using some kind of hardware wallet and I need those methods to be public for signing/sending transactions via card. Is there any specific reason why they are private?
I need the encode method for the second encode after reading out r,s and v values and calling TransactionEncoder.createEip155SignatureData.
The recoverFromSignature is needed for getting the V byte.