-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code generator correction #711
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a concern re: the option of a Credentials class being removed.
classBuilder.addMethod(buildConstructor(TransactionManager.class, | ||
TRANSACTION_MANAGER)); | ||
classBuilder.addFields(buildFuncNameConstants(abi)); | ||
classBuilder.addMethods( | ||
buildFunctionDefinitions(className, classBuilder, abi)); | ||
classBuilder.addMethod(buildLoad(className, Credentials.class, CREDENTIALS)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should be able to provide a TransactionManager or Credentials in a generated class - this looks like it removes the credentials.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me roll back this commit and get the 3.6 out, given that more work needs to be done on this.
cherry-picked this commit and applied comment in #725 |
What does this PR do?
both of these changes introduce the ContractGasProvider in the generated
code
Where should the reviewer start?
Why is it needed?