refactor(shoelace): tests failed to check hidden menu #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8e4e1ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 78.00% 78.02% +0.01%
==========================================
Files 166 166
Lines 7635 7641 +6
Branches 587 588 +1
==========================================
+ Hits 5956 5962 +6
Misses 1653 1653
Partials 26 26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -20,7 +25,7 @@ export class ShSlAutocomplete extends LitElement { | |||
| @property({ type: String }) | |||
| inputValue = '' | |||
|
|
|||
| @property({ type: Boolean, reflect: true }) | |||
There was a problem hiding this comment.
Yes. Reflect is to keep a sync between HTML element attribute and property value.
https://lit.dev/docs/components/properties/#reflected-attributes
cristianvasquez
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor and fix a brittle test which failed #236
Apparently it's a bad idea to have a reflected boolean attribute set to false