-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the most recently released version when comparing versions #39
Conversation
add test for skipping Unreleased sections
Thanks @hawkrives, makes sense to me!
|
Looks like the test is failing in iojs too: https://travis-ci.org/ngoldman/gh-release/jobs/84983915 I need to update |
Sure thing! I was trying to figure out why that wasn't working… guess I'm too used to es6. Is ES5 OK for a target? |
|
That's pretty much what I was thinking. Crossing fingers... |
@hawkrives yeah that's fine, most of ES5 has been supported in v8 for a long time. http://kangax.github.io/compat-table/es5/ helps me remember what's what (blessings unto @kangax). |
Indeed. Would you like a second PR for updating |
Use the most recently released version when comparing versions
Thanks @hawkrives! I'll take care of the |
Thanks! |
The prior behavior would error if you had an "unreleased" section at the top of your changelog.
I like to keep the section there, even empty, so that I don't have to remember to add it back in when I need to add an entry.
This finds the first changelog entry with a non-null version, rather than just the first changelog entry.