sklearn
compatible hyperopt_estimator
constructor
#169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referring to #168, there is an issue with
sklearn
'sget_params
method called onHyperoptEstimator
sinceHyperoptEstimator
does no adhere to the the constructor guidelines ofsklearn
. In particular, the constructor (__init__
) should copy all constructor arguments to attributes of the same name and not contain any logic.This pull request fixes this issue by pulling the constructor logic into a new
_init
method and calling that method only infit
.