Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some error in hyperopt spark code #813

Merged
merged 1 commit into from
Sep 15, 2021

Conversation

WeichenXu123
Copy link
Contributor

Fix some error in hyperopt spark code. Current code overwrite self._job_group_id and self._job_desc to be None due to negligence.

@WeichenXu123
Copy link
Contributor Author

WeichenXu123 commented Sep 15, 2021

Test passed :

# install pyspark 3.2
pip install --force-reinstall https://dist.apache.org/repos/dist/dev/spark/v3.2.0-rc2-bin/pyspark-3.2.0.tar.gz
pytest hyperopt/tests/test_spark.py 

@WeichenXu123
Copy link
Contributor Author

@maxpumperla Could you help review and merge ? Thanks!

@maxpumperla
Copy link
Contributor

good catch, thanks.

@maxpumperla maxpumperla merged commit 1751483 into hyperopt:master Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants