Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use UINavigationBar #82

Merged
merged 2 commits into from
Jan 10, 2018
Merged

Use UINavigationBar #82

merged 2 commits into from
Jan 10, 2018

Conversation

onmyway133
Copy link
Contributor

  • We had a bug that we can't touch on close button in HeaderView because button and label are outside HeaderView frame
  • Use UINavigationBar and a few constraints. So that we don't have to do manual layout

@vadymmarkov
Copy link
Contributor

@onmyway133 What will happen if you push this controller to navigation bar?

onmyway133
onmyway133 commented Jan 10, 2018
View reviewed changes
Sources/BarcodeScannerController.swift

headerView.isHidden = !isBeingPresented

if navigationController != nil {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadymmarkov If there's a navigation controller, we simply set the titleView

@onmyway133 onmyway133 merged commit 508aba9 into master Jan 10, 2018
@onmyway133 onmyway133 deleted the fix/bar branch January 10, 2018 11:53
@onmyway133 onmyway133 mentioned this pull request Jan 10, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadymmarkov vadymmarkov vadymmarkov approved these changes

@zenangst zenangst Awaiting requested review from zenangst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onmyway133 @vadymmarkov