Feature/identifier #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,6 +100,7 @@ public struct ViewModel: Mappable { | |||
| */ | |||
| public init(_ map: JSONDictionary) { | |||
| index <- map.property(.Index) | |||
| identifier = map.property(.Identifier) | |||
There was a problem hiding this comment.
@zenangst Shouldn't it be identifier <- map.property(.Identifier)?
There was a problem hiding this comment.
The compiler threw a bunch of complaints when trying to assign a value to something that is yet to be initialized using that operator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new property to the
ViewModel. The new property is calledIdentifierand is of typeInt. This can be used to achieve uniqueness in your view models. It can represent an ID that you get from your backend or it can be a computedStringthat you assign yourself.When assigning String, you can do so by passing the hash value for that string.