Re: Allow for the disk cache to be stored in a different location #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's apply the last changes
…ay. Make file manager be constant to avoid potential problem with concurrency because of lazy initialization. Simplify syntax of creation
# Conflicts: # Source/Shared/BasicHybridCache.swift
|
@letko-dmitry, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vadymmarkov and @RamonGilabert to be potential reviewers. |
|
Is smth wrong with it or just not needed? |
|
Hi @letko-dmitry. Thanks for your contribution! It looks good for me. Could you please resolve conflicts and we can merge it then. What do you guys think @zenangst @onmyway133 ? |
|
I think this looks good! ⭐ |
# Conflicts: # Tests/iOS/Specs/Storage/DiskStorageSpec.swift
|
Here it is. |
|
@letko-dmitry Thanks ;) |
|
Cool. Thank you ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Let's try to complete work done in the #70. I've added simple tests to check if custom directory isn't specified by default. Are there any advices about additional tests?
Thanks in advance.