-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues in iPad landscape #104
Conversation
@@ -256,27 +258,6 @@ class CameraView: UIViewController { | |||
delegate?.imageToLibrary() | |||
} | |||
|
|||
func cropImage(image: UIImage) -> UIImage { | |||
guard let imageReference = CGImageCreateWithImageInRect(image.CGImage, | |||
CGRect(x: 0, y: 0, width: image.size.height - 285, height: image.size.width)) else { return UIImage() } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway: why was here UIImage() returned instead of the input parameter?
Update: I also added a configuration flag to set if the collectionView should be hide itself while the photo is being taken. The default behaviour is unchanged. |
For some reason Travis doesn't pass. Could you check that @BenchR267? |
Was the error why it failed.. I don't know how the CI configuration is done but that should not cause an error. Is it possible to just restart the build @RamonGilabert? |
@BenchR267 try removing |
…ipad # Conflicts: # .travis.yml
Seems to work now, thanks 👍 I also merged the master to resolve merge conflicts. |
Fixed issues in iPad landscape
Fixes issues when started in landscape. Check #100