Fixed issues in iPad landscape #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -256,27 +258,6 @@ class CameraView: UIViewController { | |||
| delegate?.imageToLibrary() | |||
| } | |||
|
|
|||
| func cropImage(image: UIImage) -> UIImage { | |||
| guard let imageReference = CGImageCreateWithImageInRect(image.CGImage, | |||
| CGRect(x: 0, y: 0, width: image.size.height - 285, height: image.size.width)) else { return UIImage() } | |||
There was a problem hiding this comment.
Anyway: why was here UIImage() returned instead of the input parameter?
|
Update: I also added a configuration flag to set if the collectionView should be hide itself while the photo is being taken. The default behaviour is unchanged. |
|
For some reason Travis doesn't pass. Could you check that @BenchR267? |
|
Was the error why it failed.. I don't know how the CI configuration is done but that should not cause an error. Is it possible to just restart the build @RamonGilabert? |
|
@BenchR267 try removing |
…ipad # Conflicts: # .travis.yml
|
Seems to work now, thanks 👍 I also merged the master to resolve merge conflicts. |
zenangst
added a commit
that referenced
this pull request
Feb 14, 2016
Fixed issues in iPad landscape
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues when started in landscape. Check #100