-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/external configuration #40
Conversation
@@ -1,6 +1,13 @@ | |||
import UIKit | |||
|
|||
public class PickerConfiguration { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it could be just Configuration
with var imagePicker
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, but I don't want to conflict with Lightbox and stuff like that, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you can use it like ImagePicker.Configuration
, with module name, and also - do we have something else except ImagePickerConfiguration
, I mean why do we need 2 classes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes just thought about it, changing it!
@vadymmarkov done I guess? 😄 |
Feature/external configuration
No description provided.