Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse code between iOS and macOS #26

Merged
merged 7 commits into from Jun 27, 2016
Merged

Reuse code between iOS and macOS #26

merged 7 commits into from Jun 27, 2016

Conversation

onmyway133
Copy link
Contributor

@onmyway133 onmyway133 commented Jun 27, 2016 •
edited

As a follow up to #24

  • Use typelias Image and ImageView to reuse code
  • The Decompressor is a bit different. So make it separate
  • Add Configuration, as using Imaginary takes away the namespace
  • Add ImaginaryForMac to demo Imaginary in macOS. Yeah macOS

window 2016-06-27 13-37-09

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @zenangst and @vadymmarkov to be potential reviewers

@vadymmarkov vadymmarkov merged commit 4ab2007 into master Jun 27, 2016
@vadymmarkov vadymmarkov deleted the improve/image branch June 27, 2016 11:53
@vadymmarkov
Copy link
Contributor

@onmyway133 This is great 🚀

@zenangst
Copy link
Contributor

Fantastic! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@zenangst zenangst

@vadymmarkov vadymmarkov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@onmyway133 @mention-bot @vadymmarkov @zenangst