Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update closure reference #35

Merged
merged 2 commits into from
Nov 21, 2016
Merged

Update closure reference #35

merged 2 commits into from
Nov 21, 2016

Conversation

onmyway133
Copy link
Contributor

@onmyway133 onmyway133 commented Nov 18, 2016

From testing https://gist.github.com/onmyway133/0c76f56c52e4c3a4c0d705481dfaacbc, I see that there's nothing wrong. But I think it's easy to reason with another helper function

  • Running Thead Sanitizer, we have some warnings about accessing fetcher from main queue and from cache queue. This fixes by wrapping the call inside main queue so that actions are processed serially

@mention-bot
Copy link

@onmyway133, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zenangst, @vadymmarkov and @RamonGilabert to be potential reviewers.

@zenangst
Copy link
Contributor

Very nice find @onmyway133 !

@onmyway133
Copy link
Contributor Author

What do you think @hyperoslo/ios

@zenangst zenangst merged commit 0afaadc into master Nov 21, 2016
@zenangst zenangst deleted the fix/closure branch November 21, 2016 10:44
@zenangst
Copy link
Contributor

@onmyway133 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants