-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/refactor #80
Fix/refactor #80
Conversation
@onmyway133, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zenangst, @licvido and @vadymmarkov to be potential reviewers |
@@ -27,4 +27,14 @@ public extension String { | |||
func trim() -> String { | |||
return stringByTrimmingCharactersInSet(NSCharacterSet.whitespaceCharacterSet()) | |||
} | |||
|
|||
var uppercaseFirstLetter: String { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this the same as capitalizedString?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vadymmarkov ah, it's just the first letter that will be uppercase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
capitalizedString
A string with the first character in each word changed to its corresponding uppercase value, and all remaining characters set to their corresponding lowercase values.
@onmyway133 Any specific reason for removing |
@aashishdhawan that is of little use and serves only |
yep, i was going through Spots' code and saw same functions. I thought these were also implemented in Sugar therefore i came here to check these and found that these have been deleted. Any ways, no worries. I felt that these are important in context of Sugar ( i personally use these extension quite often, Ah..again personal preferences.) |
findFirst
to SequenceTypeuppercaseFirstLetter
to String