Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/refactor #80

Merged
merged 6 commits into from
Jul 1, 2016
Merged

Fix/refactor #80

merged 6 commits into from
Jul 1, 2016

Conversation

onmyway133
Copy link
Contributor

  • Remove Indexes extensions
  • Add findFirst to SequenceType
  • Add uppercaseFirstLetter to String
  • Update README

@mention-bot
Copy link

@onmyway133, thanks for your PR! By analyzing the annotation information on this pull request, we identified @zenangst, @licvido and @vadymmarkov to be potential reviewers

@zenangst zenangst merged commit c3347e9 into master Jul 1, 2016
@zenangst zenangst deleted the fix/refactor branch July 1, 2016 19:44
@zenangst
Copy link
Contributor

zenangst commented Jul 1, 2016

@onmyway133 😁

@@ -27,4 +27,14 @@ public extension String {
func trim() -> String {
return stringByTrimmingCharactersInSet(NSCharacterSet.whitespaceCharacterSet())
}

var uppercaseFirstLetter: String {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this the same as capitalizedString?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadymmarkov ah, it's just the first letter that will be uppercase

Copy link
Contributor

@zenangst zenangst Jul 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalizedString

A string with the first character in each word changed to its corresponding uppercase value, and all remaining characters set to their corresponding lowercase values.

@aashishdhawan
Copy link
Contributor

@onmyway133 Any specific reason for removing UITableView+Indexes and UICollectionView+Indexes?

@onmyway133
Copy link
Contributor Author

onmyway133 commented Jan 13, 2017

@aashishdhawan that is of little use and serves only Spots, and it has been moved to Spots, right @zenangst ?

@aashishdhawan
Copy link
Contributor

aashishdhawan commented Jan 13, 2017

yep, i was going through Spots' code and saw same functions. I thought these were also implemented in Sugar therefore i came here to check these and found that these have been deleted.

Any ways, no worries. I felt that these are important in context of Sugar ( i personally use these extension quite often, Ah..again personal preferences.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants