Add isPushNotificationEnabled #99
Conversation
|
@onmyway133, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zenangst, @vadymmarkov and @RamonGilabert to be potential reviewers. |
|
@onmyway133 nifty! 👍 |
There was a problem hiding this comment.
Added some comments. Basically this does not cover all cases on iOS 10, for example if the user goes into settings and disables notifications after they've been registered. Happy to help you improve this @onmyway133 🙂 Also, how about adding a test for this new API?
|
|
||
| public struct Utilities { | ||
|
|
||
| public static var isPushNotificationEnabled: Bool { |
There was a problem hiding this comment.
Since there are many push notifications, I think this should be pluralized to become isPushNotificationsEnabled
| return false | ||
| } | ||
|
|
||
| return UIApplication.shared.isRegisteredForRemoteNotifications |
There was a problem hiding this comment.
This is not enough on iOS 10. It only checks if the app is registered for notifications, not if they are actually enabled. To check that, you need to call UNUserNotificationCenter.getNotificationSettings(), and check the setting's authorizationStatus.
| public struct Utilities { | ||
|
|
||
| public static var isPushNotificationEnabled: Bool { | ||
| guard let settings = UIApplication.shared.currentUserNotificationSettings else { |
There was a problem hiding this comment.
You should also check that settings.types isn't empty.
There was a problem hiding this comment.
I have && !settings.types.isEmpty at the bottom
There was a problem hiding this comment.
Oh, you're right. Missed that, sorry 😓
This method can come in handy when we need to check if push notification can really be delivered to the app