Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename global functions #104

Merged
merged 4 commits into from
Aug 1, 2016
Merged

Rename global functions #104

merged 4 commits into from
Aug 1, 2016

Conversation

onmyway133
Copy link
Contributor

As a follow up to #89

  • Add show/hide functions, which make it easy to remember. If we ever have more kinds of message, we can do the same way
  • Make use of first parameter name in function to specify the type of UI, so we have something like
show(whisper: message, to: navigationController, action: .Present)
hide(whisper: navigationController, after: 3)
show(whistle: murmur, action: .Present)

@mention-bot
Copy link

@onmyway133, thanks for your PR! By analyzing the annotation information on this pull request, we identified @RamonGilabert and @vadymmarkov to be potential reviewers

@RamonGilabert RamonGilabert merged commit 3301c64 into master Aug 1, 2016
@RamonGilabert RamonGilabert deleted the fix/refactor branch August 1, 2016 08:30
@onmyway133 onmyway133 mentioned this pull request Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants