Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --disable-tests configure option #190

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Conversation

Radvendii
Copy link
Contributor

@Radvendii Radvendii commented Apr 23, 2021

i was cross-compiling for windows statically, and the only thing that wasn't building were the tests. I am applying this patch locally to allow me to disable building the tests, so I figured I would upstream it.

@hyperrealm
Copy link
Owner

What were the build errors with the tests on Windows? It used to work so I'm curious what's broken now.

@hyperrealm hyperrealm merged commit 2cce045 into hyperrealm:master Apr 27, 2021
@Radvendii
Copy link
Contributor Author

Thanks! the full log is below. Bear in mind (1) this is compiling statically for windows, and (2) I'm using Nix to build it, so that might also be interfering with something.

https://gist.github.com/Radvendii/1ba388efefdf00e3d579f0236da18a43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants