Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and clarification notes #1

Merged
merged 2 commits into from
May 7, 2020
Merged

Fixes and clarification notes #1

merged 2 commits into from
May 7, 2020

Conversation

jordiferrero
Copy link
Contributor

I have added some changes of issues (which didn't stop the package from working but made understanding more confusing).

ericpre
ericpre reviewed May 7, 2020
View reviewed changes
Copy link
Member

@ericpre ericpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this is useful. There are indeed a few things which are not clear. Once you address the comments, I will merge and follow up with a PR to clarify a few things.

azure-pipelines.yml Show resolved Hide resolved
azure-pipelines.yml Outdated Show resolved Hide resolved
@ericpre ericpre mentioned this pull request May 7, 2020
Closed
@jordiferrero
Copy link
Contributor Author

jordiferrero commented May 7, 2020 •
edited
Loading

UPDATE:
So I have followed the explanation of using Travis for pip and Azure for conda (which means installing though the conda_environment.yml files and adding the --no-deps in the pip package install and now everything makes more sense and it's working without the need to the [tests].

Therefore, now all comments have been addressed but I would clarify that in the README (especially the clarification of using Travis and Azure for different means).

@ericpre ericpre merged commit e376839 into hyperspy:master May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericpre ericpre ericpre left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jordiferrero @ericpre