-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecosystem as table #57
Conversation
Is it possible to a minimum width to the left columns? When the width of the page is small, the logo appear very small. The advantage of the page is that it responds well to the width and the number of card on a line is reduce as the page width is reduce. |
@ericpre also on mobile you have the same problem :) |
It would have to switch to icons, when the size of the logos gets too small, but I am not sure if that is possible. |
Hmm.... There is probably a way but I don't think it's a big enough deal to stop this from merging, It does make me realize that pyxem probably needs a more banner like logo :) |
I am pretty happy with the eXSpy logo in this context. But I am less happy how the holographic effect in the holoSpy logo renders here. I need to touch that one again. |
If I increase the size of the banners and first column a little more, like in the last commit. It already looks better for a scaled down width. |
If banner style logo are used with a large aspect ratio, the second column can be removed? The alternative is to used the non-banner logo with a 1:1 aspect ratio and keep the second column. |
Done here: pyxem/pyxem#984 (comment)
@magnunor I might take a crack at a redesign to the atomap logo if you are interested. (I really want to make the logo into an A...)
What about if we do the Rosttasciio thing and put the UI in the hypercube?
I made some suggestions in hyperspy/holospy#20 |
I need to stop making logos... @magnunor thoughts? It needs a little more cleaning up but I think the idea is there. |
Looks cool! I'll have a more thorough look at it after I sort out the HyperSpy 2.0.0 compatible Atomap release (my current dev-time is sadly quite small at the moment...) |
I still see a point in having the additional spelled out package name, as it is read quicker than a logo with varying font. At the same time, the banners look better than 1:1 icons in the table. Would be only if one replaces that for narrow windows, but then that would require quite some customization that could break more easily.
I am not a fan of badges, as they do not match so well with the pydata-sphinx style. We could however think about adding more |
By the way, on a small mobile screen, the banners in the table are simply left out, which is not a too bad solution, because the essential information remains! |
By the way, in your screenshot the SVGs are scaled correctly, while the PNGs (pyxem, Atomap) are squeezed. |
I don't know but from reading the documentation of |
OK, I checked on a few more devices. In some cases the images are reduced in size, in some they seem to disappear when they are scaled too small. |
I adapted the css so that it drops the second column (text titles) when the screen is not wide enough. When it becomes less than 400px wide it switches to text titles and drops the images. Now to look really good we only need banners for:
And an svg version (because it properly scales in contrast to png) for:
|
It seems that this is now working as expected. Using a table instead of the tile of the cards better fit the content but I find it visually less pleasing but maybe it simply needs tweaking of the table formatting? For example:
If we add any other links (such as link to source code, pypi, documentation, etc.) in the rows, we should make each row a button and that will allow us to remove the second column. |
I managed to do all proposed tweaks in the css - adapted for both dark and light mode.
The links are all going to the documentation (for HyperSpy still has to be adapted, because it goes back to the website currently). From there you can access source code, etc. - So for the moment, I do not see a need for additional links. |
@jlaehne Does this work? |
Sorry if didn't make sense what I said because I forgot a negation... I meant to say "If we don't add any other link" to suggest to remove the link as the whole line could be used as a button when hoovering. |
The holospy logo bright and dark doesn't seem to be aligned? |
Thanks, should be fixed, now also added to hyperspy/holospy#26 Also, the pyxem logo works nice (just had to set For Atomap, ParticleSpy and HyperSpyUI I created some placeholder banners so that we can merge this. Can be replaced once proper banners are available for the respective packages. |
Well, though the logos are visually appealing, with the different fonts and stylized letters, one needs longer to read the names. To get a quick overview of the extension names, I believe people would actually be reading the second column with its uniform font. Therefore, when the window is wide enough, I would leave that column. |
Is it worth doing something about the alignment of the holospy logos when switching between bright and dark theme? |
Should be fine now. I fixed the dark one to match the light one. |
This PR renders the Ecosystem section as table with banner logos.
Might actually help us also to assess the new banners for how they fit here!