Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameter in blind_source_separation() #1975

Closed
jat255 opened this issue Jun 7, 2018 · 2 comments
Closed

Unused parameter in blind_source_separation() #1975

jat255 opened this issue Jun 7, 2018 · 2 comments
Milestone

Comments

@jat255
Copy link
Member

jat255 commented Jun 7, 2018

There is a parameter for this method called pretreatment. It does not have a docstring, and does not appear to be used anywhere in the code. Is it needed? Should it be removed to prevent confusion?

https://github.com/hyperspy/hyperspy/blob/RELEASE_next_minor/hyperspy/learn/mva.py#L479

@thomasaarholt
Copy link
Contributor

I can't find anything about pretreatment as part of the function on scikit. I vote remove it.

@tjof2
Copy link
Contributor

tjof2 commented May 1, 2020

It's no longer there (certainly as of #2383) so this can be closed?

@ericpre ericpre added this to the v1.6 milestone May 1, 2020
@ericpre ericpre closed this as completed May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants