Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling for CL metadata in DM reader #2590

Merged
merged 7 commits into from Dec 3, 2020

Conversation

jlaehne
Copy link
Contributor

@jlaehne jlaehne commented Nov 23, 2020

Description of the change

Added import of various CL specific metadata fields to DM reader

Progress of the PR

  • Change implemented (can be split into several points),
  • update docstring (if appropriate),
  • update user guide (if appropriate),
  • add tests,
  • ready for review.

@jlaehne
Copy link
Contributor Author

jlaehne commented Nov 23, 2020

Note that #2095 touches this PR. For the moment, I have not implemented microscope specific metadata under an SEM node, but simply set the acquisition_mode parameter to SEM instead of STEM/TEM under the TEM node. Current metadata structure would require a separate node, but I think the proposal from #2095 would make sense and would result in the metadata going one level up or the TEM being renamed to a more general EM to separate it from detector specific information under Acquisition_instrument.

@jlaehne
Copy link
Contributor Author

jlaehne commented Nov 24, 2020

How do I get a codecov for this PR?

@ericpre
Copy link
Member

ericpre commented Nov 24, 2020

codecov comes from a build on travis and I am afraid that it is not working well at the moment. Until yesterday, there was a failure with latest h5py version and as of this morning there is still a failure introduced in #2437.
On top of that, travis significantly reduced their capacity of their free tier offer recently and there is now a massive queue: https://www.traviscistatus.com

@ericpre
Copy link
Member

ericpre commented Dec 1, 2020

@jlaehne, the coverage is working now!

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #2590 (4438e47) into RELEASE_next_minor (906da79) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                  Coverage Diff                   @@
##           RELEASE_next_minor    #2590      +/-   ##
======================================================
+ Coverage               76.44%   76.46%   +0.01%     
======================================================
  Files                     202      202              
  Lines                   29734    29741       +7     
  Branches                 6490     6494       +4     
======================================================
+ Hits                    22729    22740      +11     
+ Misses                   5205     5203       -2     
+ Partials                 1800     1798       -2     
Impacted Files Coverage Δ
hyperspy/io_plugins/digital_micrograph.py 67.65% <100.00%> (+0.80%) ⬆️
hyperspy/signal.py 75.61% <0.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 906da79...4438e47. Read the comment docs.

@jlaehne
Copy link
Contributor Author

jlaehne commented Dec 3, 2020

Mac build was aborted, did not fail.

@ericpre ericpre merged commit b14ed96 into hyperspy:RELEASE_next_minor Dec 3, 2020
@ericpre ericpre added this to the v1.7 milestone Dec 3, 2020
@jlaehne jlaehne deleted the dm_cl-metadata branch December 3, 2020 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants