New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CL metadata in dm-reader #2894
Update CL metadata in dm-reader #2894
Conversation
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_minor #2894 +/- ##
======================================================
+ Coverage 79.10% 79.18% +0.08%
======================================================
Files 206 206
Lines 31907 31872 -35
Branches 7181 7187 +6
======================================================
- Hits 25239 25237 -2
+ Misses 4909 4876 -33
Partials 1759 1759
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have left some suggestions for improvement.
Thanks @ericpre. Two very good points that I took up. Looking if there are easy ways to increase coverage, I realized that the functions Also, having a file with complex data would do a big job for the coverage. |
I guess, this have been used for debugging purposes but this is not documented, so I agree that this is fine to tidy it up. |
After fixing the metadata structure in LumiSpy, the mapping in the DM reader has to be updated. Implements the structure proposed in LumiSpy/lumispy#109 (and should be merged only after tis PR).
Furthermore, an SEM as microscope is now properly detected and the metadata set accordingly.
Follow up on #2590, where this mapping was first introduced. AS #2590 is still unreleased, this redesign should be included in the v1.7 release.
Progress of the PR
upcoming_changes
folder (seeupcoming_changes/README.rst
),readthedocs
doc build of this PR (link in github checks)