New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement of NeXus file IO #2725
Enhancement of NeXus file IO #2725
Conversation
Refactored getting nav_list out the _nexus_dataset_to_signal function.
Codecov Report
@@ Coverage Diff @@
## RELEASE_next_minor #2725 +/- ##
======================================================
+ Coverage 77.75% 78.00% +0.25%
======================================================
Files 203 203
Lines 30632 30688 +56
Branches 6671 6696 +25
======================================================
+ Hits 23817 23938 +121
+ Misses 5034 4995 -39
+ Partials 1781 1755 -26
Continue to review full report at Codecov.
|
Also added tests for previously uncovered codes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me - see comments.
Description of the change
The PR contains some improvement and bug fixes about the IO of NeXus file.
Besides the new options, it also adds tests to cover previously uncovered parts. Any comment is welcomed.
Progress of the PR
CHANGES.rst
,