New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: BCF xml parsing: drop lxml, use xml.etree #1750
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliminating `lxml` dependency
from lxml checks
with lxml gone, optional bcf during isntallation is gone too
Closed
Replace 'XmlClass' into '@' string which mark atrribute from xml node
into etreeelement.find(str) fix: saved element checking error: IndexError -> AttributeError
so that test comparing the python vs cython parsing would be run as last add: check if compiled cython bcf code is present to that testing function
CI checks fail not due to bcf re-implementation, but due to plotting test failures. |
This look alright. Can you please merge with |
Thanks @sem-geologist! |
This was referenced Oct 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops usage of lxml and adopts built-in xml.etree.ElementTree
Progress of the PR
io/__init__.py
),going to be very minory changed, adding the XML attributes with '@Attribute' notation)find faulty xml example (I believe I encountered one once), and adopt regex code for its fixing prior-parsing, (containing numbers in the tags: e.g.can't find such faulty bcf file. I have only bruker eds<1>good day</1>
)*.spx
and project files with messy xml tags. Without working bug example this will wait until I or somebody will find such buggy bcf file.