Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ReadTheDocs API docs #2042

Merged
merged 13 commits into from Aug 29, 2018
Merged

Fix ReadTheDocs API docs #2042

merged 13 commits into from Aug 29, 2018

Conversation

francisco-dlp
Copy link
Member

Fixes #1908

@francisco-dlp francisco-dlp added this to the v1.4 milestone Aug 28, 2018
@francisco-dlp
Copy link
Member Author

This is working fine locally with sphinx 1.7.7. However it breaks like this with sphinx 1.7.8

@francisco-dlp
Copy link
Member Author

I just opened an issue about it sphinx-doc/sphinx#5361

@francisco-dlp
Copy link
Member Author

This is now building the API properly (see example), so it is ready for review.

@ericpre
Copy link
Member

ericpre commented Aug 29, 2018

Well, I don't know how the doc build works but it seems to do the job, so we will trust you on that one! :D

@ericpre ericpre merged commit b62a5d0 into RELEASE_next_minor Aug 29, 2018
@francisco-dlp francisco-dlp deleted the FIX_RTD_apidoc branch September 1, 2018 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
affects: documentation type: bug-fix
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@francisco-dlp @ericpre